netdev - Re: [net-next 1/1] tipc: fix a potental access after delete in tipc_sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180115.134406.1797630492013260374.davem@davemloft.net>
Date:   Mon, 15 Jan 2018 13:44:06 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jon.maloy@...csson.com
Cc:     netdev@...r.kernel.org,
        mohan.krishna.ghanta.krishnamurthy@...csson.com,
        tung.q.nguyen@...tech.com.au, hoang.h.le@...tech.com.au,
        canh.d.luu@...tech.com.au, ying.xue@...driver.com,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [net-next 1/1] tipc: fix a potental access after delete in
 tipc_sk_join()

From: Jon Maloy <jon.maloy@...csson.com>
Date: Wed, 10 Jan 2018 21:08:50 +0100

> In commit d12d2e12cec2 "tipc: send out join messages as soon as new
> member is discovered") we added a call to the function tipc_group_join()
> without considering the case that the preceding tipc_sk_publish() might
> have failed, and the group item already deleted.
> 
> We fix this by returning from tipc_sk_join() directly after the
> failed tipc_sk_publish.
> 
> Reported-by: syzbot+e3eeae78ea88b8d6d858@...kaller.appspotmail.com
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Applied, thanks Jon.