netdev - Re: [PATCH v2 net-next 2/5] l2tp: double-check l2specific

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180115184425.GD1422@alphalink.fr>
Date:   Mon, 15 Jan 2018 19:44:25 +0100
From:   Guillaume Nault <g.nault@...halink.fr>
To:     Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        James Chapman <jchapman@...alix.com>
Subject: Re: [PATCH v2 net-next 2/5] l2tp: double-check l2specific_type
 provided by userspace

On Mon, Jan 15, 2018 at 07:18:17PM +0100, Lorenzo Bianconi wrote:
> > On Sun, Jan 14, 2018 at 03:50:55PM +0100, Lorenzo Bianconi wrote:
> >> Add sanity check on l2specific_type provided by userspace in
> >> l2tp_nl_cmd_session_create() since just L2TP_L2SPECTYPE_DEFAULT and
> >> L2TP_L2SPECTYPE_NONE are currently supported.
> >> Moreover do not always initialize l2specific_type if userspace requests
> >> a given l2-specific sublayer type
> >>
> > I don't understand your last sentence. l2specific_type is always
> > initialised in your patch (or session creation is aborted).
> >
> 
> I mean to explicitly set l2specific_type to L2TP_L2SPECTYPE_DEFAULT
> only if the userspace does not provide a value for it (I moved the
> 'default' initialization in the 'else' case)
> 
Ok, I thought you were talking about a functional change.