netdev - Re: [PATCH net-next v2] net: phy: remove parameter new_link from phy_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180115.134522.1443386500581434982.davem@davemloft.net>
Date:   Mon, 15 Jan 2018 13:45:22 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, opendmb@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: phy: remove parameter new_link from
 phy_mac_interrupt()

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Wed, 10 Jan 2018 21:21:31 +0100

> I see two issues with parameter new_link:
> 
> 1. It's not needed. See also phy_interrupt(), works w/o this parameter.
>    phy_mac_interrupt sets the state to PHY_CHANGELINK and triggers the
>    state machine which then calls phy_read_status. And phy_read_status
>    updates the link state.
> 
> 2. phy_mac_interrupt is used in interrupt context and getting the link
>    state may sleep (at least when having to access the PHY registers
>    via MDIO bus).
> 
> So let's remove it.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
> v2:
> - combine both patches to avoid a build failure

Applied, thank you.