netdev - Re: [PATCH bpf-next v2 02/11] net: sched: prepare extack support for offload via tc_cls_common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4828f1f-5936-cb87-a60c-b7050ca3846e@netronome.com>
Date:   Tue, 16 Jan 2018 13:08:16 +0000
From:   Quentin Monnet <quentin.monnet@...ronome.com>
To:     Jiri Pirko <jiri@...nulli.us>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     davem@...emloft.net, daniel@...earbox.net,
        alexei.starovoitov@...il.com, netdev@...r.kernel.org,
        dsahern@...il.com, oss-drivers@...ronome.com,
        john.fastabend@...il.com, jhs@...atatu.com, gerlitz.or@...il.com,
        aring@...atatu.com, xiyou.wangcong@...il.com
Subject: Re: [PATCH bpf-next v2 02/11] net: sched: prepare extack support for
 offload via tc_cls_common_offload

2018-01-16 10:33 UTC+0100 ~ Jiri Pirko <jiri@...nulli.us>
> Tue, Jan 16, 2018 at 03:08:36AM CET, jakub.kicinski@...ronome.com wrote:
>> From: Quentin Monnet <quentin.monnet@...ronome.com>
>>
>> Prepare for extack support for hardware offload of classifiers. In order
>> to achieve this, a pointer to a struct netlink_ext_ack is added to the
>> struct tc_cls_common_offload that is passed to the callback for setting
>> up the classifier. Function tc_cls_common_offload_init() is updated to
>> support initialization of this new attribute.
>>
>> Extack plumbing is not complete yet.
>>
>> Signed-off-by: Quentin Monnet <quentin.monnet@...ronome.com>
>> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
>> ---
> 
> [...]
> 
> 
>> diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c
>> index 998ee4faf934..f1640a98a3d2 100644
>> --- a/net/sched/cls_flower.c
>> +++ b/net/sched/cls_flower.c
>> @@ -223,7 +223,7 @@ static void fl_hw_destroy_filter(struct tcf_proto *tp, struct cls_fl_filter *f)
>> 	struct tc_cls_flower_offload cls_flower = {};
>> 	struct tcf_block *block = tp->chain->block;
>>
>> -	tc_cls_common_offload_init(&cls_flower.common, tp);
>> +	tc_cls_common_offload_init(&cls_flower.common, tp, NULL);
> 
> You should have the patch assing extack arg to fl_hw_replace_filter
> prior to this patch. Then you don't need this odd NULL pass.
> Same for other cls.

It makes sense, thank you Jiri. I'll address this and your comment on
patch 9, and respin.

Quentin