netdev - Re: [PATCH bpf-next v2 09/11] nfp: bpf: use extack support to improve debugging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180116093601.GB2477@nanopsycho>
Date:   Tue, 16 Jan 2018 10:36:01 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     davem@...emloft.net, daniel@...earbox.net,
        alexei.starovoitov@...il.com, netdev@...r.kernel.org,
        dsahern@...il.com, oss-drivers@...ronome.com,
        john.fastabend@...il.com, jhs@...atatu.com, gerlitz.or@...il.com,
        aring@...atatu.com, xiyou.wangcong@...il.com,
        Quentin Monnet <quentin.monnet@...ronome.com>
Subject: Re: [PATCH bpf-next v2 09/11] nfp: bpf: use extack support to
 improve debugging

Tue, Jan 16, 2018 at 03:08:43AM CET, jakub.kicinski@...ronome.com wrote:
>From: Quentin Monnet <quentin.monnet@...ronome.com>
>
>Use the recently added extack support for eBPF offload in the driver.
>
>Signed-off-by: Quentin Monnet <quentin.monnet@...ronome.com>
>Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
>---

[...]


>@@ -303,7 +305,8 @@ static int nfp_net_bpf_load(struct nfp_net *nn, struct bpf_prog *prog)
> 	/* Load up the JITed code */
> 	err = nfp_net_reconfig(nn, NFP_NET_CFG_UPDATE_BPF);
> 	if (err)
>-		nn_err(nn, "FW command error while loading BPF: %d\n", err);
>+		NL_SET_ERR_MSG_MOD(extack,
>+				   "FW command error while loading BPF");

One line please. Same for all others. Strings may overflow 80 cols.