netdev - Re: [PATCH] [RESEND net] fm10k: mark PM functions as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a27iQWGzwfDOMLj-sVquiHNPccAp0_8-2zoaqQVB0K44g@mail.gmail.com>
Date:   Tue, 16 Jan 2018 17:20:12 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     "Keller, Jacob E" <jacob.e.keller@...el.com>
Cc:     "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Kwan, Ngai-mint" <ngai-mint.kwan@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [RESEND net] fm10k: mark PM functions as __maybe_unused

On Tue, Jan 16, 2018 at 5:12 PM, Keller, Jacob E
<jacob.e.keller@...el.com> wrote:
>> -----Original Message-----
>> From: Arnd Bergmann [mailto:arnd@...db.de]
>> Sent: Tuesday, January 16, 2018 1:14 AM
>> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>
>> Cc: Arnd Bergmann <arnd@...db.de>; Keller, Jacob E
>> <jacob.e.keller@...el.com>; David S. Miller <davem@...emloft.net>; Kwan,
>> Ngai-mint <ngai-mint.kwan@...el.com>; intel-wired-lan@...ts.osuosl.org;
>> netdev@...r.kernel.org; linux-kernel@...r.kernel.org
>> Subject: [PATCH] [RESEND net] fm10k: mark PM functions as __maybe_unused
>>
>> A cleanup of the PM code left an incorrect #ifdef in place, leading
>> to a harmless build warning:
>>
>> drivers/net/ethernet/intel/fm10k/fm10k_pci.c:2502:12: error: 'fm10k_suspend'
>> defined but not used [-Werror=unused-function]
>> drivers/net/ethernet/intel/fm10k/fm10k_pci.c:2475:12: error: 'fm10k_resume'
>> defined but not used [-Werror=unused-function]
>>
>> It's easier to use __maybe_unused attributes here, since you
>> can't pick the wrong one.
>>
>> Fixes: 8249c47c6ba4 ("fm10k: use generic PM hooks instead of legacy PCIe power
>> hooks")
>> Acked-by: Jacob Keller <jacob.e.keller@...el.com>
>> Tested-by: Krishneil Singh <krishneil.k.singh@...el.com>
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>> Apparently nobody picked this up the first time around (Oct 2017),
>> here is the same patch again.
>
> Odd. I remember seeing this and thought I ack'd it..? Guess it got missed.
>
> Acked-by: Jacob Keller <jacob.e.keller@...el.com>

Yes, you did give an Ack (see above), it's just that it didn't make it
into the tree for some reason. Maybe Jeff assumed you would
forward it to him and you thought that he would pick it up from the
list?

      Arnd