netdev - Re: [PATCH net] ibmvnic: Fix pending MAC address changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180116.112633.2177995465153594050.davem@davemloft.net>
Date:   Tue, 16 Jan 2018 11:26:33 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     tlfalcon@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, nfont@...ux.vnet.ibm.com,
        jallen@...ux.vnet.ibm.com
Subject: Re: [PATCH net] ibmvnic: Fix pending MAC address changes

From: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
Date: Wed, 10 Jan 2018 19:39:52 -0600

> Due to architecture limitations, the IBM VNIC client driver is unable
> to perform MAC address changes unless the device has "logged in" to
> its backing device. Currently, pending MAC changes are handled before
> login, resulting in an error and failure to change the MAC address.
> Moving that chunk to the end of the ibmvnic_login function, when we are
> sure that it was successful, fixes that.
> 
> The MAC address can be changed when the device is up or down, so
> only check if the device is in a "PROBED" state before setting the
> MAC address.
> 
> Fixes: c26eba03e407 ("ibmvnic: Update reset infrastructure to support tunable parameters")
> Signed-off-by: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>

Applied, thanks.