netdev - Re: [PATCH net] ip6_gre: init dev->mtu and dev->hard_header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180116.113214.1563871996543889759.davem@davemloft.net>
Date:   Tue, 16 Jan 2018 11:32:14 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     alexey.kodanev@...cle.com
Cc:     netdev@...r.kernel.org, tom@...bertland.com
Subject: Re: [PATCH net] ip6_gre: init dev->mtu and dev->hard_header_len
 correctly

From: Alexey Kodanev <alexey.kodanev@...cle.com>
Date: Thu, 11 Jan 2018 16:02:54 +0300

> For ip6gretap, reset dev->mtu to zero in ip6gre_tap_setup()
> after ether_setup(), in order for it to work with the new check
> in ip6gre_tunnel_init_common().

This part is error prone.  Please instead add a new boolean argument
to ip6gre_tunnel_init_common: "bool set_mtu".  Set it to true when
it is invoked from ip6gre_tap_init() and false when it is invoked
from ip6gre_tunnel_init().

Thank you.