netdev - Re: [PATCH net-next 8/8] net: sched: cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180116135019.1db52024@cakuba.netronome.com>
Date:   Tue, 16 Jan 2018 13:50:30 -0800
From:   Jakub Kicinski <kubakici@...pl>
To:     Alexander Aring <aring@...atatu.com>
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        davem@...emloft.net, netdev@...r.kernel.org, kernel@...atatu.com,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH net-next 8/8] net: sched: cls_u32: add extack support

On Tue, 16 Jan 2018 12:20:27 -0500, Alexander Aring wrote:
> @@ -780,14 +787,18 @@ static int u32_set_parms(struct net *net, struct tcf_proto *tp,
>  		u32 handle = nla_get_u32(tb[TCA_U32_LINK]);
>  		struct tc_u_hnode *ht_down = NULL, *ht_old;
>  
> -		if (TC_U32_KEY(handle))
> +		if (TC_U32_KEY(handle)) {
> +			NL_SET_ERR_MSG(extack, "u32 Link handle must be a hash table");
>  			return -EINVAL;
> +		}

Since classifiers are commonly built as modules would it make more
sense to use NL_SET_ERR_MSG_MOD()?