netdev - Re: [PATCH net-next 2/8] net: sched: cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpWFBn10CS3BRYmxQQBBuFk=3TUJ7up7VTDRH=-Jj1-PKA@mail.gmail.com>
Date:   Tue, 16 Jan 2018 15:12:33 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Alexander Aring <aring@...atatu.com>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>,
        David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        kernel@...atatu.com, David Ahern <dsahern@...il.com>
Subject: Re: [PATCH net-next 2/8] net: sched: cls_api: handle generic cls errors

On Tue, Jan 16, 2018 at 9:20 AM, Alexander Aring <aring@...atatu.com> wrote:
> @@ -1117,8 +1146,10 @@ int tcf_exts_validate(struct net *net, struct tcf_proto *tp, struct nlattr **tb,
>         }
>  #else
>         if ((exts->action && tb[exts->action]) ||
> -           (exts->police && tb[exts->police]))
> +           (exts->police && tb[exts->police])) {
> +               NL_SET_ERR_MSG(extack, "Actions are not supported. Check compile options");
>                 return -EOPNOTSUPP;
> +       }
>  #endif

"Check compile options" is confusing, it is clearer if we can just
say we need to enable CONFIG_NET_CLS_ACT here.