netdev - Re: [PATCH net-next 7/8] net: sched: cls: add extack support for tc_setup_cb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXjebN1ZxcFjUZUjY2t2MY1i9KX2hAMr1KGihE=RuVQTQ@mail.gmail.com>
Date:   Tue, 16 Jan 2018 15:14:48 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Alexander Aring <aring@...atatu.com>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>,
        David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        kernel@...atatu.com, David Ahern <dsahern@...il.com>
Subject: Re: [PATCH net-next 7/8] net: sched: cls: add extack support for tc_setup_cb_call

On Tue, Jan 16, 2018 at 9:20 AM, Alexander Aring <aring@...atatu.com> wrote:
>  int tc_setup_cb_call(struct tcf_block *block, struct tcf_exts *exts,
> -                    enum tc_setup_type type, void *type_data, bool err_stop)
> +                    enum tc_setup_type type, void *type_data, bool err_stop,
> +                    struct netlink_ext_ack *extack)
>  {
>         int ok_count;
>         int ret;
>
>         ret = tcf_block_cb_call(block, type, type_data, err_stop);
> -       if (ret < 0)
> +       if (ret < 0) {
> +               NL_SET_ERR_MSG(extack, "Failed to inialize tcf block");


s/inialize/initialize/

>                 return ret;
> +       }
>         ok_count = ret;
>
>         if (!exts)
>                 return ok_count;
>         ret = tc_exts_setup_cb_egdev_call(exts, type, type_data, err_stop);
> -       if (ret < 0)
> +       if (ret < 0) {
> +               NL_SET_ERR_MSG(extack, "Failed to inialize tcf block extensions");

Ditto.