netdev - Re: [PATCH net 1/3] tls: fix sw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180117.161624.1345521825925383427.davem@davemloft.net>
Date:   Wed, 17 Jan 2018 16:16:24 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     sd@...asysnail.net
Cc:     netdev@...r.kernel.org, ilyal@...lanox.com, borisp@...lanox.com,
        aviadye@...lanox.com, davejwatson@...com
Subject: Re: [PATCH net 1/3] tls: fix sw_ctx leak

From: Sabrina Dubroca <sd@...asysnail.net>
Date: Tue, 16 Jan 2018 16:04:26 +0100

> During setsockopt(SOL_TCP, TLS_TX), if initialization of the software
> context fails in tls_set_sw_offload(), we leak sw_ctx. We also don't
> reassign ctx->priv_ctx to NULL, so we can't even do another attempt to
> set it up on the same socket, as it will fail with -EEXIST.
> 
> Fixes: 3c4d7559159b ('tls: kernel TLS support')
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>

Applied.