netdev - [PATCH net-next] net/dim: Fix fixpoint divide exception in net_dim_stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1516223596-11684-1-git-send-email-talgi@mellanox.com>
Date:   Wed, 17 Jan 2018 23:13:16 +0200
From:   Tal Gilboa <talgi@...lanox.com>
To:     "David S. Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, Tariq Toukan <tariqt@...lanox.com>,
        Tal Gilboa <talgi@...lanox.com>,
        Andy Gospodarek <andrew.gospodarek@...adcom.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Talat Batheesh <talatb@...lanox.com>
Subject: [PATCH net-next] net/dim: Fix fixpoint divide exception in net_dim_stats_compare

From: Talat Batheesh <talatb@...lanox.com>

Helmut reported a bug about devision by zero while
running traffic and doing physical cable pull test.

When the cable unplugged the ppms become zero, so when
dividing the current ppms by the previous ppms in the
next dim iteration there is devision by zero.

This patch prevent this division for both ppms and epms.

Fixes: c3164d2fc48f ("net/mlx5e: Added BW check for DIM decision mechanism")
Fixes: 4c4dbb4a7363 ("net/mlx5e: Move dynamic interrupt coalescing code to include/linux")
Reported-by: Helmut Grauer <helmut.grauer@...ibm.com>
Signed-off-by: Talat Batheesh <talatb@...lanox.com>
Signed-off-by: Tal Gilboa <talgi@...lanox.com>
---
 include/linux/net_dim.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/include/linux/net_dim.h b/include/linux/net_dim.h
index 1c7e450..bebeaad 100644
--- a/include/linux/net_dim.h
+++ b/include/linux/net_dim.h
@@ -244,10 +244,17 @@ static inline int net_dim_stats_compare(struct net_dim_stats *curr,
 		return (curr->bpms > prev->bpms) ? NET_DIM_STATS_BETTER :
 						   NET_DIM_STATS_WORSE;
 
+	if (!prev->ppms)
+		return curr->ppms ? NET_DIM_STATS_BETTER :
+				    NET_DIM_STATS_SAME;
+
 	if (IS_SIGNIFICANT_DIFF(curr->ppms, prev->ppms))
 		return (curr->ppms > prev->ppms) ? NET_DIM_STATS_BETTER :
 						   NET_DIM_STATS_WORSE;
 
+	if (!prev->epms)
+		return NET_DIM_STATS_SAME;
+
 	if (IS_SIGNIFICANT_DIFF(curr->epms, prev->epms))
 		return (curr->epms < prev->epms) ? NET_DIM_STATS_BETTER :
 						   NET_DIM_STATS_WORSE;
-- 
1.8.3.1