netdev - Re: [PATCH net-next] net/dim: Fix fixpoint divide exception in net_dim_stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180119.145402.1348645331747765089.davem@davemloft.net>
Date:   Fri, 19 Jan 2018 14:54:02 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     talgi@...lanox.com
Cc:     netdev@...r.kernel.org, tariqt@...lanox.com,
        andrew.gospodarek@...adcom.com, saeedm@...lanox.com,
        talatb@...lanox.com
Subject: Re: [PATCH net-next] net/dim: Fix fixpoint divide exception in
 net_dim_stats_compare

From: Tal Gilboa <talgi@...lanox.com>
Date: Wed, 17 Jan 2018 23:13:16 +0200

> From: Talat Batheesh <talatb@...lanox.com>
> 
> Helmut reported a bug about devision by zero while
> running traffic and doing physical cable pull test.
> 
> When the cable unplugged the ppms become zero, so when
> dividing the current ppms by the previous ppms in the
> next dim iteration there is devision by zero.
> 
> This patch prevent this division for both ppms and epms.
> 
> Fixes: c3164d2fc48f ("net/mlx5e: Added BW check for DIM decision mechanism")
> Fixes: 4c4dbb4a7363 ("net/mlx5e: Move dynamic interrupt coalescing code to include/linux")
> Reported-by: Helmut Grauer <helmut.grauer@...ibm.com>
> Signed-off-by: Talat Batheesh <talatb@...lanox.com>
> Signed-off-by: Tal Gilboa <talgi@...lanox.com>

Applied, thanks.