netdev - Re: [PATCH net] netlink: reset extack earlier in netlink_rcv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4750213-c1d4-117c-5752-5de775135a4a@gmail.com>
Date:   Thu, 18 Jan 2018 09:10:51 -0800
From:   David Ahern <dsahern@...il.com>
To:     Xin Long <lucien.xin@...il.com>,
        network dev <netdev@...r.kernel.org>
Cc:     davem@...emloft.net
Subject: Re: [PATCH net] netlink: reset extack earlier in netlink_rcv_skb

On 1/17/18 10:48 PM, Xin Long wrote:
> Move up the extack reset/initialization in netlink_rcv_skb, so that
> those 'goto ack' will not skip it. Otherwise, later on netlink_ack
> may use the uninitialized extack and cause kernel crash.
> 
> Fixes: cbbdf8433a5f ("netlink: extack needs to be reset each time through loop")
> Reported-by: syzbot+03bee3680a37466775e7@...kaller.appspotmail.com
> Signed-off-by: Xin Long <lucien.xin@...il.com>
> ---
>  net/netlink/af_netlink.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: David Ahern <dsahern@...il.com>