netdev - Re: [PATCH net] netlink: reset extack earlier in netlink_rcv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 Jan 2018 15:15:30 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...il.com
Cc:     lucien.xin@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] netlink: reset extack earlier in netlink_rcv_skb

From: David Ahern <dsahern@...il.com>
Date: Thu, 18 Jan 2018 09:10:51 -0800

> On 1/17/18 10:48 PM, Xin Long wrote:
>> Move up the extack reset/initialization in netlink_rcv_skb, so that
>> those 'goto ack' will not skip it. Otherwise, later on netlink_ack
>> may use the uninitialized extack and cause kernel crash.
>> 
>> Fixes: cbbdf8433a5f ("netlink: extack needs to be reset each time through loop")
>> Reported-by: syzbot+03bee3680a37466775e7@...kaller.appspotmail.com
>> Signed-off-by: Xin Long <lucien.xin@...il.com>
>> ---
>>  net/netlink/af_netlink.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
> 
> Acked-by: David Ahern <dsahern@...il.com>

Applied and queued up for -stable, thank you.