netdev - Re: [PATCH net] ipv6: don't let tb6_root node share routes with other node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180118.211446.1437094078738888938.davem@davemloft.net>
Date:   Thu, 18 Jan 2018 21:14:46 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     weiwan@...gle.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, kafai@...com
Subject: Re: [PATCH net] ipv6: don't let tb6_root node share routes with
 other node

From: Wei Wang <weiwan@...gle.com>
Date: Thu, 18 Jan 2018 10:40:03 -0800

> From: Wei Wang <weiwan@...gle.com>
> 
> After commit 4512c43eac7e, if we add a route to the subtree of tb6_root
> which does not have any route attached to it yet, the current code will
> let tb6_root and the node in the subtree share the same route.
> This could cause problem cause tb6_root has RTN_INFO flag marked and the
> tree repair and clean up code will not work properly.
> This commit makes sure tb6_root->leaf points back to null_entry instead
> of sharing route with other node.
> 
> It fixes the following syzkaller reported issue:
 ...
> Fixes: 4512c43eac7e ("ipv6: remove null_entry before adding default route")
> Signed-off-by: Wei Wang <weiwan@...gle.com>
> Acked-by: Eric Dumazet <edumazet@...gle.com>

Applied, thank you.