netdev - Re: [PATCH net] xfrm: Add SA to hardware at the end of xfrm_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180119100554.pezcpqj7g6gzsckl@gauss3.secunet.de>
Date:   Fri, 19 Jan 2018 11:05:54 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     <yossiku@...lanox.com>
CC:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Aviad Yehezkel <aviadye@...lnaox.com>,
        "Aviv Heller" <avivh@...lanox.com>
Subject: Re: [PATCH net] xfrm: Add SA to hardware at the end of
 xfrm_state_construct()

On Wed, Jan 17, 2018 at 03:52:41PM +0200, yossiku@...lanox.com wrote:
> From: Yossi Kuperman <yossiku@...lanox.com>
> 
> Current code configures the hardware with a new SA before the state has been
> fully initialized. During this time interval, an incoming ESP packet can cause
> a crash due to a NULL dereference. More specifically, xfrm_input() considers
> the packet as valid, and yet, anti-replay mechanism is not initialized.
> 
> Move hardware configuration to the end of xfrm_state_construct(), and mark
> the state as valid once the SA is fully initialized.
> 
> Fixes: d77e38e612a0 ("xfrm: Add an IPsec hardware offloading API")
> Signed-off-by: Aviad Yehezkel <aviadye@...lnaox.com>
> Signed-off-by: Aviv Heller <avivh@...lanox.com>
> Signed-off-by: Yossi Kuperman <yossiku@...lanox.com>

Applied, thanks Yossi!