netdev - Re: [PATCH xfrm v1] xfrm: fix error flow in case of add state fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180119100635.czgyglo7s5zg27x6@gauss3.secunet.de>
Date:   Fri, 19 Jan 2018 11:06:35 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Aviad Yehezkel <aviadye@...lanox.com>
CC:     <davem@...emloft.net>, <herbert@...dor.apana.org.au>,
        <netdev@...r.kernel.org>, Boris Pismeny <borisp@...lanox.com>
Subject: Re: [PATCH xfrm v1] xfrm: fix error flow in case of add state fails

On Thu, Jan 18, 2018 at 03:41:51PM +0200, Aviad Yehezkel wrote:
> If add state fails in case of device offload, netdev refcount
> will be negative since gc task is attempting to dev_free this state.
> This is fixed by putting NULL in state dev field.
> 
> Signed-off-by: Aviad Yehezkel <aviadye@...lanox.com>
> Signed-off-by: Boris Pismeny <borisp@...lanox.com>

Applied, thanks!