netdev - Re: [PATCH v6 31/36] dt-bindings: nds32 CPU Bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2noraQFvJbi2=T+rb3KDfZ88zJWQ_h3dYjD2ArhLPM1Q@mail.gmail.com>
Date:   Mon, 22 Jan 2018 12:15:47 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Greentime Hu <green.hu@...il.com>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Greentime <greentime@...estech.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Networking <netdev@...r.kernel.org>,
        Vincent Chen <deanbo422@...il.com>,
        DTML <devicetree@...r.kernel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        David Howells <dhowells@...hat.com>,
        Will Deacon <will.deacon@....com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        linux-serial@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Mark Rutland <mark.rutland@....com>, Greg KH <greg@...ah.com>,
        Guo Ren <ren_guo@...ky.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        David Miller <davem@...emloft.net>,
        Jonas Bonn <jonas@...thpole.se>,
        Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
        Stafford Horne <shorne@...il.com>,
        Vincent Chen <vincentc@...estech.com>,
        Rick Chen <rick@...estech.com>, Zong Li <zong@...estech.com>
Subject: Re: [PATCH v6 31/36] dt-bindings: nds32 CPU Bindings

On Mon, Jan 22, 2018 at 10:53 AM, Greentime Hu <green.hu@...il.com> wrote:
> 2018-01-19 23:37 GMT+08:00 Geert Uytterhoeven <geert@...ux-m68k.org>:
>> On Fri, Jan 19, 2018 at 4:35 PM, Greentime Hu <green.hu@...il.com> wrote:
>>> 2018-01-19 23:29 GMT+08:00 Geert Uytterhoeven <geert@...ux-m68k.org>:
>>>> On Fri, Jan 19, 2018 at 4:18 PM, Greentime Hu <green.hu@...il.com> wrote:

>>> Thank you and your example.
>>> I get it. I will update this document like this.
>>> - compatible: Should be "andestech,<core_name>", "andestech,nds32v3"
>>> as fallback.
>>
>> And please keep a list of supported values of "andestech,<core_name>"
>> in the DT binding document, so checkpatch can validate compatible values.
>>
>
> Thank you for reminding me this.
> I will list it like this.
>
> - compatible:
>         Usage: required
>         Value type: <string>
>         Definition: Should be "andestech,<core_name>",
> "andestech,nds32v3" as fallback.
>         Examlpes with core_names are:
>         "andestech,n13"
>         "andestech,n15"
>         "andestech,d15"
>         "andestech,n10"
>         "andestech,d10"

This is still not written as a proper specification, you should not
give "examples"
but give a complete list of the available options. You could write it like:

Must contain "andestech,nds32v3" as the most generic value, in addition to
one of the following identifiers for a particular CPU core:
         "andestech,n13"
         "andestech,n15"
         "andestech,d15"
         "andestech,n10"
         "andestech,d10"

It might be helpful to also list all other existing nds32v3 cores,
even those that the
current Linux port does not support them.

      Arnd