netdev - Re: [PATCH net-next v2 2/2] net/sched: act_csum: don't use spinlock in the fast path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 22 Jan 2018 12:16:59 +0100
From:   Davide Caratti <dcaratti@...hat.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH net-next v2 2/2] net/sched: act_csum: don't use
 spinlock in the fast path

hello Cong,
On Sun, 2018-01-21 at 12:28 -0800, Cong Wang wrote:
> > +       params = rcu_dereference(p->params);
> 
> I think you need rtnl_dereference() here, as we don't have RCU read lock here?

you are right, thank you for spotting this.
I will send v3 series today.

regards,

-- 
davide