netdev - Re: [PATCH iproute2-next v2 8/8] ip/tunnel: Unify local/remote endpoint address printing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe0cabd5-ee9a-f94d-1dcd-6f223cd36cf0@gmail.com>
Date:   Wed, 24 Jan 2018 11:40:02 -0700
From:   David Ahern <dsahern@...il.com>
To:     Serhey Popovych <serhe.popovych@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next v2 8/8] ip/tunnel: Unify local/remote
 endpoint address printing

On 1/23/18 12:19 PM, Serhey Popovych wrote:
> Introduce and use tnl_print_endpoint() helper to print
> of tunnel endpoint address.
> 
> Note that for AF_INET and AF_INET6 inet_ntop(3) is used
> that may return NULL in case of failure and while unlikely
> format_host_rta() might return NULL too. Handle this case
> when passing local/remote to print_string().
> 
> Signed-off-by: Serhey Popovych <serhe.popovych@...il.com>
> ---
>  ip/link_gre.c    |   21 ++-------------------
>  ip/link_gre6.c   |   26 ++------------------------
>  ip/link_ip6tnl.c |   15 ++-------------
>  ip/link_iptnl.c  |   21 ++-------------------
>  ip/link_vti.c    |   21 ++-------------------
>  ip/link_vti6.c   |   21 ++-------------------
>  ip/tunnel.c      |   27 +++++++++++++++++++++++++++
>  ip/tunnel.h      |    2 ++
>  8 files changed, 41 insertions(+), 113 deletions(-)
> 
>

This one no longer applies cleanly after the latest merge to master.
Please update -- and fix the commit messages to use more than 50 columns.