netdev - Re: [PATCH iproute2-next v2 0/8] ip: Introduce and use get_addr_rta()/inet_addr_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Jan 2018 20:45:14 -0700
From:   David Ahern <dsahern@...il.com>
To:     Serhey Popovych <serhe.popovych@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next v2 0/8] ip: Introduce and use
 get_addr_rta()/inet_addr_match_rta()

On 1/23/18 12:19 PM, Serhey Popovych wrote:
> Now we enhance get_addr() to return additional
> information about address (e.g. if it unspecified
> or multicast) we want to have same functionality
> for attributes in netlink message.
> 
> Introduce and use get_addr_rta() that parses
> given netlink attribute into @inet_prefix
> data structure in the same way similar get_addr()
> parses address from it's string representation.
> 
> Use attribute length to guess address family:
> force it by giving non AF_UNSPEC @family to
> get_addr_rta() to ensure address is of expected
> family.
> 
> Introduce and use inet_addr_match_rta() to further
> simplify and unify code where get_addr_rta()
> intended to be used together with inet_addr_match().
> 
> This is next step in ipv4 and ipv6 modules
> unification to prepare for merge in the future.
> 
> Any comments, suggestions and criticism as always
> welcome.

No need to resend this set, but in the future your commit messages can
use say 72 characters per line. You seem to be line wrapping between 50
and 60 characters.