netdev - Re: [PATCH net] net: don't call update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <088bdcd5-f6d7-bd7b-03ae-e70ad381bff5@gmail.com>
Date:   Thu, 25 Jan 2018 11:08:54 -0700
From:   David Ahern <dsahern@...il.com>
To:     Nicolas Dichtel <nicolas.dichtel@...nd.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, code@...pl.cz, lucien.xin@...il.com,
        jbenc@...hat.com, pablo@...filter.org, edumazet@...gle.com,
        tgraf@...g.ch
Subject: Re: [PATCH net] net: don't call update_pmtu unconditionally

On 1/25/18 11:03 AM, Nicolas Dichtel wrote:
> diff --git a/include/net/dst.h b/include/net/dst.h
> index b091fd536098..6216edb58393 100644
> --- a/include/net/dst.h
> +++ b/include/net/dst.h
> @@ -521,4 +521,12 @@ static inline struct xfrm_state *dst_xfrm(const struct dst_entry *dst)
>  }
>  #endif
>  
> +static inline void skb_dst_update_pmtu(struct sk_buff *skb, u32 mtu)
> +{
> +	struct dst_entry *dst = skb_dst(skb);
> +
> +	if (dst && dst->ops->update_pmtu)
> +		skb_dst(skb)->ops->update_pmtu(dst, NULL, skb, mtu);

in that last line, s/skb_dst(skb)/dst/