netdev - Re: [PATCH net] net: don't call update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180125.162801.425615148241706142.davem@davemloft.net>
Date:   Thu, 25 Jan 2018 16:28:01 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     nicolas.dichtel@...nd.com
Cc:     netdev@...r.kernel.org, code@...pl.cz, lucien.xin@...il.com,
        jbenc@...hat.com, pablo@...filter.org, edumazet@...gle.com,
        dsahern@...il.com, tgraf@...g.ch
Subject: Re: [PATCH net] net: don't call update_pmtu unconditionally

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Thu, 25 Jan 2018 19:03:03 +0100

> Some dst_ops (e.g. md_dst_ops)) doesn't set this handler. It may result to:
> "BUG: unable to handle kernel NULL pointer dereference at           (null)"
> 
> Let's add a helper to check if update_pmtu is available before calling it.
> 
> Fixes: 52a589d51f10 ("geneve: update skb dst pmtu on tx path")
> Fixes: a93bf0ff4490 ("vxlan: update skb dst pmtu on tx path")
> CC: Roman Kapl <code@...pl.cz>
> CC: Xin Long <lucien.xin@...il.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Applied with the fixup suggested by David Ahern and queued up for -stable,
thank you!