netdev - Re: [PATCH v3 net-next] net/ipv6: Do not allow route add with a device that is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180125.162225.662426645378111324.davem@davemloft.net>
Date:   Thu, 25 Jan 2018 16:22:25 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next] net/ipv6: Do not allow route add with a
 device that is down

From: David Ahern <dsahern@...il.com>
Date: Wed, 24 Jan 2018 19:45:29 -0800

> IPv6 allows routes to be installed when the device is not up (admin up).
> Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really
> there is no reason for IPv6 to allow it, so check the flags and deny if
> device is admin down.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>
> ---
> v3
> - moved err=-ENETDOWN under the if check per Eric's request
> - left the up check using dev->flags for consistency with IPv4
>   and that it is used more often in ipv4 and ivp6 code than
>   netif_running
> 
> v2
> - missed setting err to -ENETDOWN (thanks for catching that Roopa)

Applied, thanks David.