netdev - Re: [PATCH] inet: Avoid unitialized variable warning in inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3QoF9Xv3sq-2D3YtZJSVZx0nCkzmfOX93zJfBviocA3A@mail.gmail.com>
Date:   Thu, 1 Feb 2018 12:48:59 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Networking <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] inet: Avoid unitialized variable warning in inet_unhash()

On Thu, Feb 1, 2018 at 11:26 AM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> With gcc-4.1.2:
>
>     net/ipv4/inet_hashtables.c: In function ‘inet_unhash’:
>     net/ipv4/inet_hashtables.c:628: warning: ‘ilb’ may be used uninitialized in this function
>
> While this is a false positive, it can easily be avoided by using the
> pointer itself as the canary variable.
>
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Looks like a reasonable workaround if we care about it. gcc-4.3 and higher
don't seem to produce this warning, so I wouldn't normally care though.

Acked-by: Arnd Bergmann <arnd@...db.de>