netdev - Re: [PATCH] inet: Avoid unitialized variable warning in inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180201.094909.1943860277381269232.davem@davemloft.net>
Date:   Thu, 01 Feb 2018 09:49:09 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     geert@...ux-m68k.org
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org, arnd@...db.de,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] inet: Avoid unitialized variable warning in
 inet_unhash()

From: Geert Uytterhoeven <geert@...ux-m68k.org>
Date: Thu,  1 Feb 2018 11:26:23 +0100

> With gcc-4.1.2:
> 
>     net/ipv4/inet_hashtables.c: In function ‘inet_unhash’:
>     net/ipv4/inet_hashtables.c:628: warning: ‘ilb’ may be used uninitialized in this function
> 
> While this is a false positive, it can easily be avoided by using the
> pointer itself as the canary variable.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

This frankly also makes the logic simpler and doesn't increase register
pressure, I like it.

Applied, thanks.