netdev - Re: [PATCH iproute2 v1] ip netns: allow negative nsid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPP7u0WjMDMyLk5bdH1vFXSo-uT69A4Kvhn+47ejQU_YcX0xvA@mail.gmail.com>
Date:   Thu, 8 Feb 2018 23:50:30 +0100
From:   Christian Brauner <christian.brauner@...onical.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Christian Brauner <christian.brauner@...ntu.com>,
        Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2 v1] ip netns: allow negative nsid

On Thu, Feb 8, 2018 at 5:01 PM, Stephen Hemminger
<stephen@...workplumber.org> wrote:
> On Tue,  6 Feb 2018 19:39:31 +0100
> Christian Brauner <christian.brauner@...ntu.com> wrote:
>
>> If the kernel receives a negative nsid it will automatically assign the
>> next available nsid. In this case alloc_netid() will set min and max to
>> 0 for ird_alloc(). And when max == 0 idr_alloc() will interpret this as
>> the maxium range, i.e. specific to nsids it will try to find an id in
>> the range [0,INT_MAX). This is intentionally supported in the kernel for
>> nsids. Commit acbe9118ce8086f765ffb0da15f80c7c01a8903a regressed ip
>> netns in that respect although previously the use-case was either
>> accidentally supported or opaquely supported such that it triggered the
>> original commit. From what I can gather it went as follows before:
>> atoi() was called with a string indicating a negative value which caused
>> it to return -1 which was passed to the kernel. Let's make it less
>> opaque by introducing the keyword "auto":
>>
>> ip netns set <netns-name> auto
>>
>> will cause nsid to be set to -1 and the kernel will select an available
>> nsid.
>>
>> Signed-off-by: Christian Brauner <christian.brauner@...ntu.com>
>
> Applied thank you.
> I did have to fix spelling and format of commit reference in
> the commit description. If you run checkpatch on patches to
> iproute you would have caught that.

Ah, sorry about that. Didn't think about applying checkpatch to iproute
patches as well. Won't happen again!

Thanks for applying.
Christian