netdev - Re: [PATCH net 1/1 v4] rtnetlink: require unique netns identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPP7u0XPASDL1t5yJ8nGF9jnkxSBowyMWEYvi8m--6DF2s93GA@mail.gmail.com>
Date:   Thu, 8 Feb 2018 23:55:43 +0100
From:   Christian Brauner <christian.brauner@...onical.com>
To:     David Miller <davem@...emloft.net>
Cc:     Christian Brauner <christian.brauner@...ntu.com>,
        Netdev <netdev@...r.kernel.org>,
        Kirill Tkhai <ktkhai@...tuozzo.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        w.bumiller@...xmox.com,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Jiri Benc <jbenc@...hat.com>,
        Nicolas Dichtel <nicolas.dichtel@...nd.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH net 1/1 v4] rtnetlink: require unique netns identifier

On Thu, Feb 8, 2018 at 8:33 PM, David Miller <davem@...emloft.net> wrote:
> From: Christian Brauner <christian.brauner@...ntu.com>
> Date: Wed,  7 Feb 2018 13:53:20 +0100
>
>> Since we've added support for IFLA_IF_NETNSID for RTM_{DEL,GET,SET,NEW}LINK
>> it is possible for userspace to send us requests with three different
>> properties to identify a target network namespace. This affects at least
>> RTM_{NEW,SET}LINK. Each of them could potentially refer to a different
>> network namespace which is confusing. For legacy reasons the kernel will
>> pick the IFLA_NET_NS_PID property first and then look for the
>> IFLA_NET_NS_FD property but there is no reason to extend this type of
>> behavior to network namespace ids. The regression potential is quite
>> minimal since the rtnetlink requests in question either won't allow
>> IFLA_IF_NETNSID requests before 4.16 is out (RTM_{NEW,SET}LINK) or don't
>> support IFLA_NET_NS_{PID,FD} (RTM_{DEL,GET}LINK) in the first place.
>>
>> Signed-off-by: Christian Brauner <christian.brauner@...ntu.com>
>
> Applied, thanks Christian.

Thanks for applying, David.