netdev - Re: [PATCH net-next 7/8] net: sched: act: handle extack in tcf_generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180213.111818.1744624787176430479.davem@davemloft.net>
Date:   Tue, 13 Feb 2018 11:18:18 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dcaratti@...hat.com
Cc:     aring@...atatu.com, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, netdev@...r.kernel.org, dsahern@...il.com
Subject: Re: [PATCH net-next 7/8] net: sched: act: handle extack in
 tcf_generic_walker

From: Davide Caratti <dcaratti@...hat.com>
Date: Tue, 13 Feb 2018 10:58:01 +0100

> On Mon, 2018-02-12 at 15:19 -0500, Alexander Aring wrote:
>>  
>> @@ -211,7 +212,8 @@ int tcf_generic_walker(struct tc_action_net *tn, struct sk_buff *skb,
>>  	} else if (type == RTM_GETACTION) {
>>  		return tcf_dump_walker(idrinfo, skb, cb);
>>  	} else {
>> -		WARN(1, "tcf_generic_walker: unknown action %d\n", type);
>> +		WARN(1, "tcf_generic_walker: unknown command %d\n", type);
>> +		NL_SET_ERR_MSG(extack, "tcf_generic_walker: unknown command\n");
> 
> minor nit: maybe we don't need the '\n' in the above message? 

Agreed, the newline should be removed.