netdev - Re: [PATCH net-next 7/8] net: sched: act: handle extack in tcf_generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAB_54W7SL_Tf1TZMXmbJiU4+nrWOFy+=ModxucKLUamY_4q26Q@mail.gmail.com>
Date:   Tue, 13 Feb 2018 11:58:11 -0500
From:   Alexander Aring <alex.aring@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     dcaratti@...hat.com, Alexander Aring <aring@...atatu.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        xiyou.wangcong@...il.com, Jiri Pirko <jiri@...nulli.us>,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
        dsahern@...il.com
Subject: Re: [PATCH net-next 7/8] net: sched: act: handle extack in tcf_generic_walker

Hi,

2018-02-13 11:18 GMT-05:00 David Miller <davem@...emloft.net>:
> From: Davide Caratti <dcaratti@...hat.com>
> Date: Tue, 13 Feb 2018 10:58:01 +0100
>
>> On Mon, 2018-02-12 at 15:19 -0500, Alexander Aring wrote:
>>>
>>> @@ -211,7 +212,8 @@ int tcf_generic_walker(struct tc_action_net *tn, struct sk_buff *skb,
>>>      } else if (type == RTM_GETACTION) {
>>>              return tcf_dump_walker(idrinfo, skb, cb);
>>>      } else {
>>> -            WARN(1, "tcf_generic_walker: unknown action %d\n", type);
>>> +            WARN(1, "tcf_generic_walker: unknown command %d\n", type);
>>> +            NL_SET_ERR_MSG(extack, "tcf_generic_walker: unknown command\n");
>>
>> minor nit: maybe we don't need the '\n' in the above message?
>

Yep, I will send v2.

Thanks.

- Alex