netdev - Re: [PATCH net v3] tipc: fix missing RTNL lock protection during setting link properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d41eda9f-8a68-09d4-e7e0-f053c8383020@windriver.com>
Date:   Wed, 14 Feb 2018 13:40:14 +0800
From:   Ying Xue <ying.xue@...driver.com>
To:     Kirill Tkhai <ktkhai@...tuozzo.com>, <davem@...emloft.net>,
        <jon.maloy@...csson.com>
CC:     <netdev@...r.kernel.org>, <syzkaller-bugs@...glegroups.com>,
        <tipc-discussion@...ts.sourceforge.net>
Subject: Re: [PATCH net v3] tipc: fix missing RTNL lock protection during
 setting link properties

On 02/13/2018 07:03 PM, Kirill Tkhai wrote:
> The patch is logically OK for me. The only thing I'm confused,
> I had to split it in 7 patches to review, otherwise the patch
> looks difficult to do. There is possible to extract:
> 
> 1)Refactoring in __tipc_nl_compat_doit
> 2)Introduce __tipc_nl_bearer_disable()
> 3)Introduce __tipc_nl_bearer_enable()
> 4)Introduce __tipc_nl_bearer_set()
> 5)Introduce __tipc_nl_media_set()
> 6)Introduce __tipc_nl_net_set()
> 7)tipc: fix missing RTNL lock protection during setting link properties
> 
> After that it becomes very easy to review the change you made in this patch.
> 
> I attached them to message, and you may take the patches if there is one
> more version.

Thank you very much for your suggested patches! I have revised them
based on your idea and sent out v4 version. Please review them.

Thanks,
Ying