netdev - Re: [PATCH] PCI/cxgb4: Extend T3 PCI quirk to T4+ devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 16 Feb 2018 15:42:46 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ganeshgr@...lsio.com
Cc:     bhelgaas@...gle.com, linux-pci@...r.kernel.org,
        netdev@...r.kernel.org, hare@...e.de, nirranjan@...lsio.com,
        indranil@...lsio.com, venkatesh@...lsio.com, leedom@...lsio.com,
        stable@...r.kernel.org, arjun@...lsio.com
Subject: Re: [PATCH] PCI/cxgb4: Extend T3 PCI quirk to T4+ devices

From: Ganesh Goudar <ganeshgr@...lsio.com>
Date: Thu, 15 Feb 2018 20:03:18 +0530

> From: Casey Leedom <leedom@...lsio.com>
> 
> We've run into a problem where our device is attached
> to a Virtual Machine and the use of the new pci_set_vpd_size()
> API doesn't help.  The VM kernel has been informed that
> the accesses are okay, but all of the actual VPD Capability
> Accesses are trapped down into the KVM Hypervisor where it
> goes ahead and imposes the silent denials.
> 
> The right idea is to follow the kernel.org
> commit 1c7de2b4ff88 ("PCI: Enable access to non-standard VPD for
> Chelsio devices (cxgb3)") which Alexey Kardashevskiy authored
> to establish a PCI Quirk for our T3-based adapters. This commit
> extends that PCI Quirk to cover Chelsio T4 devices and later.
> 
> The advantage of this approach is that the VPD Size gets set early
> in the Base OS/Hypervisor Boot and doesn't require that the cxgb4
> driver even be available in the Base OS/Hypervisor.  Thus PF4 can
> be exported to a Virtual Machine and everything should work.
> 
> Fixes: 67e658794ca1 ("cxgb4: Set VPD size so we can read both VPD structures")
> Cc: <stable@...r.kernel.org>  # v4.9+
> Signed-off-by: Casey Leedom <leedom@...lsio.com>
> Signed-off-by: Arjun Vynipadath <arjun@...lsio.com>
> Signed-off-by: Ganesh Goudar <ganeshgr@...lsio.com>

Applied, thanks.