netdev - Re: [PATCH net] net: sched: fix unbalance in the error path of tca_action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 16 Feb 2018 15:43:39 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dcaratti@...hat.com
Cc:     jiri@...nulli.us, xiyou.wangcong@...il.com, jhs@...atatu.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] net: sched: fix unbalance in the error path of
 tca_action_flush()

From: Davide Caratti <dcaratti@...hat.com>
Date: Thu, 15 Feb 2018 15:50:57 +0100

> When tca_action_flush() calls the action walk() and gets an error,
> a successful call to nla_nest_start() is not followed by a call to
> nla_nest_cancel(). It's harmless, as the skb is freed in the error
> path - but it's worth to fix this unbalance.
> 
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>

Applied to net-next, thanks.