netdev - Re: [PATCH net-next 0/6] tcp: remove non GSO code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iL3Bd-+Bq2srDMAzh6OOQM_dxCC6_b_pUesXtnVAGigbA@mail.gmail.com>
Date:   Tue, 20 Feb 2018 11:39:49 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Oleksandr Natalenko <oleksandr@...alenko.name>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Neal Cardwell <ncardwell@...gle.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>
Subject: Re: [PATCH net-next 0/6] tcp: remove non GSO code

On Tue, Feb 20, 2018 at 11:35 AM, Oleksandr Natalenko
<oleksandr@...alenko.name> wrote:
> Hi.
>
> On úterý 20. února 2018 19:57:42 CET Eric Dumazet wrote:
>> Actually timer drifts are not horrible (at least on my lab hosts)
>>
>> But BBR has a pessimistic way to sense the burst size, as it is tied to
>> TSO/GSO being there.
>>
>> Following patch helps a lot.
>
> Not really, at least if applied to v4.15.4. Still getting 2 Gbps less between
> VMs if using BBR instead of Reno.
>
> Am I doing something wrong?

I am not trying to compare BBR and Reno on a lossless link.

Reno is running as fast as possible and will win when bufferbloat is
not an issue.

If bufferbloat is not an issue, simply use Reno and be happy ;)

My patch helps BBR only, I thought it was obvious ;)