netdev - Re: [PATCH iproute2-next] ip: don't colorize the master device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b39b111c-bbb7-5384-6532-738ee464fd48@gmail.com>
Date:   Tue, 20 Feb 2018 13:18:18 -0700
From:   David Ahern <dsahern@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>,
        netdev@...r.kernel.org
Cc:     Stephen Hemminger <sthemmin@...rosoft.com>
Subject: Re: [PATCH iproute2-next] ip: don't colorize the master device

On 2/20/18 12:08 PM, Stephen Hemminger wrote:
> From: Stephen Hemminger <sthemmin@...rosoft.com>
> 
> Putting whole string "master eth0" in the interface name color
> is wrong and confusing. Let's just turn color off for all attributes
> of device.
> 
> Fixes: d92cc2d087b0 ("ipaddress: ll_map: Replace ll_idx_n2a() with ll_index_to_name()")
> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
> ---
>  ip/ipaddress.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 

Change in behavior too. Applied to iproute2-next