netdev - Re: [PATCH iproute2-next v2] ip link: add support to display extended tun attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <28e7a400-051e-d55e-e3fa-a385d2681f89@gmail.com>
Date:   Tue, 20 Feb 2018 13:19:05 -0700
From:   David Ahern <dsahern@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Sabrina Dubroca <sd@...asysnail.net>, netdev@...r.kernel.org,
        sbrivio@...hat.com, serhe.popovych@...il.com
Subject: Re: [PATCH iproute2-next v2] ip link: add support to display extended
 tun attributes

On 2/20/18 11:40 AM, Stephen Hemminger wrote:
>>> diff --git a/ip/iptuntap.c b/ip/iptuntap.c
>>> index 4628db2832b4..07253870472f 100644
>>> --- a/ip/iptuntap.c
>>> +++ b/ip/iptuntap.c
>>> @@ -469,3 +469,89 @@ int do_iptuntap(int argc, char **argv)
>>>  		*argv);
>>>  	exit(-1);
>>>  }
>>> +
>>> +static void print_owner(FILE *f, uid_t uid)
>>> +{
>>> +	struct passwd *pw = getpwuid(uid);
>>> +
>>> +	if (pw)
>>> +		fprintf(f, "user %s ", pw->pw_name);
>>> +	else
>>> +		fprintf(f, "user %u ", uid);
>>> +}
>>> +
>>> +static void print_group(FILE *f, gid_t gid)
>>> +{
>>> +	struct group *group = getgrgid(gid);
>>> +
>>> +	if (group)
>>> +		fprintf(f, "group %s ", group->gr_name);
>>> +	else
>>> +		fprintf(f, "group %u ", gid);
>>> +}
>>> +  
>>
>>
>> Those helpers can be re-used to make 'ip tuntap show' better too.
> 
> These should support JSON output.
> 

Good point. Missed that detail. Sabrina: Please send a patch to fix the
json output.