netdev - Re: [PATCH iproute2-next v2 2/7] iplink: Correctly report error when network device isn't found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2c67d30-1a85-305c-9b7b-f0f7c86cd056@gmail.com>
Date:   Tue, 20 Feb 2018 22:15:22 -0700
From:   David Ahern <dsahern@...il.com>
To:     Serhey Popovych <serhe.popovych@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next v2 2/7] iplink: Correctly report error when
 network device isn't found

On 2/20/18 2:37 PM, Serhey Popovych wrote:
> Distinguish cases when "dev" parameter isn't given from cases where no
> network device corresponding to "dev" is found.
> 
> Do not check for index validity in xdp_parse(): caller should take care
> of this because has more information (e.g. when "dev" is given or not
> found) for this.
> 
> Signed-off-by: Serhey Popovych <serhe.popovych@...il.com>
> ---
>  ip/iplink.c     |   16 +++++++++++++---
>  ip/iplink_xdp.c |    7 +------
>  2 files changed, 14 insertions(+), 9 deletions(-)
> 

don't really see any benefit from this one.