netdev - Re: [PATCH RFC net-next 16/20] net/ipv6: Cleanup exception route handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180226.142746.1107269119562830375.davem@davemloft.net>
Date:   Mon, 26 Feb 2018 14:27:46 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...il.com
Cc:     netdev@...r.kernel.org, idosch@...sch.org,
        roopa@...ulusnetworks.com, eric.dumazet@...il.com,
        weiwan@...gle.com, kafai@...com, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH RFC net-next 16/20] net/ipv6: Cleanup exception route
 handling

From: David Ahern <dsahern@...il.com>
Date: Sun, 25 Feb 2018 11:47:26 -0800

> IPv6 FIB will only contain FIB entries with exception routes added to
> the FIB entry. Remove CACHE and dst checks from fib6 add and delete since
> they can never happen once the data type changes.
> 
> Fixup the lookup functions to use a f6i name for fib lookups and retain
> the current rt name for return variables.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>

Hard to interpret what you mean in that second paragraph.

Do you mean that this invariant holds after patch #19 only?  Then you
really can't make these simplifications until then in order to keep
the patch series bisectable.

Otherwise you mean something else and I'd like to know what that is.

Either way, the commit message wording could be improved since even
a dolt like me got confused :-)