netdev - Re: [PATCH RFC net-next 01/20] net: Move fib_convert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6fc83fa-2e96-7c10-f0cd-52e3d5328fe3@gmail.com>
Date:   Mon, 26 Feb 2018 13:07:27 -0700
From:   David Ahern <dsahern@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, idosch@...sch.org,
        roopa@...ulusnetworks.com, eric.dumazet@...il.com,
        weiwan@...gle.com, kafai@...com, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH RFC net-next 01/20] net: Move fib_convert_metrics to dst
 core

On 2/26/18 12:05 PM, David Miller wrote:
> From: David Ahern <dsahern@...il.com>
> Date: Sun, 25 Feb 2018 11:47:11 -0800
> 
>> diff --git a/net/core/dst.c b/net/core/dst.c
>> index 007aa0b08291..5f70bc832bec 100644
>> --- a/net/core/dst.c
>> +++ b/net/core/dst.c
> ...
>> +			val = tcp_ca_get_key_by_name(net, tmp, &ecn_ca);
>> +			if (val == TCP_CA_UNSPEC)
>> +				return -EINVAL;
> 
> This makes the networking core depend upon CONFIG_INET.
> 
> You will have to untangle this somehow before your final submission.
> Probably with an inline helper in the non-INET case that always
> returns TCP_CA_UNSPEC.
> 

good point. Perhaps net/ipv4/metrics.c is a better place for it given
that ipv4/ipv6 common code appears to be under net/ipv4. I need to play
with the config build permutations.