netdev - Re: [PATCH net-next 02/14] selftests: forwarding: Add a test for FDB learning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180226200217.GB4195@splinter>
Date:   Mon, 26 Feb 2018 22:02:17 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     Petr Machata <petrm@...lanox.com>
Cc:     Ido Schimmel <idosch@...lanox.com>, netdev@...r.kernel.org,
        linux-kselftest@...r.kernel.org, davem@...emloft.net,
        shuah@...nel.org, jiri@...lanox.com, dsahern@...il.com,
        roopa@...ulusnetworks.com, nikolay@...ulusnetworks.com,
        f.fainelli@...il.com, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com, mlxsw@...lanox.com
Subject: Re: [PATCH net-next 02/14] selftests: forwarding: Add a test for FDB
 learning

On Mon, Feb 26, 2018 at 06:31:49PM +0200, Petr Machata wrote:
> Ido Schimmel <idosch@...lanox.com> writes:
> 
> > +learning_test()
> > +{
> > +	local mac=de:ad:be:ef:13:37
> > +	local ageing_time
> > +	local br_port1=$2	# Connected to `host1_if`.
> > +	local host1_if=$3
> > +	local host2_if=$4
> > +	local bridge=$1
> 
> I don't think applying RXT in Bash is appropriate. The ordering of the
> local variables should instead follow the order of function arguments,
> because that information isn't communicated by the function prototype
> itself, unlike C.

Makes sense. Will fix. Thanks!