netdev - Re: [PATCH net-next 02/14] selftests: forwarding: Add a test for FDB learning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <wih4lm3pv9m.fsf@dev-r-vrt-156.mtr.labs.mlnx>
Date:   Mon, 26 Feb 2018 18:31:49 +0200
From:   Petr Machata <petrm@...lanox.com>
To:     Ido Schimmel <idosch@...lanox.com>
Cc:     netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
        davem@...emloft.net, shuah@...nel.org, jiri@...lanox.com,
        dsahern@...il.com, roopa@...ulusnetworks.com,
        nikolay@...ulusnetworks.com, f.fainelli@...il.com, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com, mlxsw@...lanox.com
Subject: Re: [PATCH net-next 02/14] selftests: forwarding: Add a test for FDB learning

Ido Schimmel <idosch@...lanox.com> writes:

> +learning_test()
> +{
> +	local mac=de:ad:be:ef:13:37
> +	local ageing_time
> +	local br_port1=$2	# Connected to `host1_if`.
> +	local host1_if=$3
> +	local host2_if=$4
> +	local bridge=$1

I don't think applying RXT in Bash is appropriate. The ordering of the
local variables should instead follow the order of function arguments,
because that information isn't communicated by the function prototype
itself, unlike C.

Thanks,
Petr