netdev - Re: [PATCH net-next 01/14] selftests: forwarding: Add initial testing framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180226134802.GC1195@lunn.ch>
Date:   Mon, 26 Feb 2018 14:48:02 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Ido Schimmel <idosch@...lanox.com>
Cc:     netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
        davem@...emloft.net, shuah@...nel.org, jiri@...lanox.com,
        dsahern@...il.com, roopa@...ulusnetworks.com,
        nikolay@...ulusnetworks.com, f.fainelli@...il.com,
        vivien.didelot@...oirfairelinux.com, mlxsw@...lanox.com
Subject: Re: [PATCH net-next 01/14] selftests: forwarding: Add initial
 testing framework

> +                             br0
> +                              +
> +               vrf-h1         |           vrf-h2
> +                 +        +---+----+        +
> +                 |        |        |        |
> +    192.0.2.1/24 +        +        +        + 192.0.2.2/24
> +               swp1     swp2     swp3     swp4
> +                 +        +        +        +
> +                 |        |        |        |
> +                 +--------+        +--------+
> +

> +setup_prepare
> +setup_wait
> +
> +ping_test $h1 192.0.2.2
> +ping6_test $h1 2001:db8:1::2

How about putting 192.0.2.3/24 on br0, and pinging to/from
it. Otherwise you don't test the slow path. 

I would also suggest a much simpler first test.

> +                             
> +                              
> +               vrf-h1                                         vrf-h2
> +                 +                                              +
> +                 |                                              |
> +    192.0.2.1/24 +        + 192.0.2.2/24  192.0.3.1/24 +        + 192.0.3.2/24
> +               swp1     swp2                          swp3     swp4
> +                 +        +                            +        +
> +                 |        |                            |        |
> +                 +--------+                            +--------+

Ping from 192.0.2.1 to 192.0.2.2 and test there are 0 packets seen on
swp3 and swp4. I've seen DSA drivers get this wrong before, forgetting
to ensure ports are properly separated by default.

   Andrew