netdev - Re: [PATCH] ip_tunnel: Do not use mark in skb by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180226.152736.1516734752419128681.davem@redhat.com>
Date:   Mon, 26 Feb 2018 15:27:36 -0500 (EST)
From:   David Miller <davem@...hat.com>
To:     Thomas.Winter@...iedtelesis.co.nz
Cc:     netdev@...r.kernel.org, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH] ip_tunnel: Do not use mark in skb by default

From: Thomas Winter <Thomas.Winter@...iedtelesis.co.nz>
Date: Mon, 26 Feb 2018 10:28:10 +1300

> This reverts commit 5c38bd1b82e1f76f9fa96c1e61c9897cabf1ce45.
> 
> skb->mark contains the mark the encapsulated traffic which
> can result in incorrect routing decisions being made such
> as routing loops if the route chosen is via tunnel itself.
> The correct method should be to use tunnel->fwmark.
> 
> Signed-off-by: Thomas Winter <thomas.winter@...iedtelesis.co.nz>

Applied, thank you.