netdev - Re: [PATCH RFC net-next 08/20] net/ipv6: Defer initialization of dst to data path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180226.152205.1019314339567047877.davem@redhat.com>
Date:   Mon, 26 Feb 2018 15:22:05 -0500 (EST)
From:   David Miller <davem@...hat.com>
To:     dsahern@...il.com
Cc:     netdev@...r.kernel.org, idosch@...sch.org,
        roopa@...ulusnetworks.com, eric.dumazet@...il.com,
        weiwan@...gle.com, kafai@...com, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH RFC net-next 08/20] net/ipv6: Defer initialization of
 dst to data path

From: David Ahern <dsahern@...il.com>
Date: Mon, 26 Feb 2018 13:20:27 -0700

> +static void ip6_rt_init_dst(struct rt6_info *rt, struct rt6_info *ort)
> +{
> +	if (ort->rt6i_flags & RTF_REJECT) {
> +		ip6_rt_init_dst_reject(rt, ort);
> +		return;
> +	}
> +
> +	rt->dst.error = 0;
> +	rt->dst.output = ip6_output;
> +
> +...
> 
> So for reject routes we have the above helper which is basically a code
> move from ip6_route_info_create.
> 
> For non-reject routes dst.error is 0 which is the rest of ip6_rt_init_dst.

My bad, thanks for explaining things to me.  The flag bit test above
completely escaped my eyes for some reason. :)