netdev - Re: [PATCH RFC net-next 02/20] vrf: Move fib6_table into net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180226.153415.1078585316493629955.davem@redhat.com>
Date:   Mon, 26 Feb 2018 15:34:15 -0500 (EST)
From:   David Miller <davem@...hat.com>
To:     dsahern@...il.com
Cc:     netdev@...r.kernel.org, idosch@...sch.org,
        roopa@...ulusnetworks.com, eric.dumazet@...il.com,
        weiwan@...gle.com, kafai@...com, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH RFC net-next 02/20] vrf: Move fib6_table into net_vrf

From: David Ahern <dsahern@...il.com>
Date: Mon, 26 Feb 2018 13:13:24 -0700

> On 2/26/18 12:08 PM, David Miller wrote:
>> From: David Ahern <dsahern@...il.com>
>> Date: Sun, 25 Feb 2018 11:47:12 -0800
>> 
>>> A later patch removes rt6i_table from rt6_info. Save the ipv6
>>> table for a VRF in net_vrf. fib tables can not be deleted so
>>> no reference counting or locking is required.
>>>
>>> Signed-off-by: David Ahern <dsahern@...il.com>
>> 
>> Is this change really OK all by itself?
> 
> should. When you look at references to rt6i_table the only one for the
> data path is changing sernum when inserting an exception. Exceptions are
> not relevant for this special VRF dst as it is used for an internal
> redirection before packets leave the box.
 ...
> But if you want me to be extra cautious I can leave the rt6i_table
> setting and remove it in patch 20 (remove unneeded rt6_info elements).

No, it's not necessary if it is really an isolated object like this.