netdev - Re: [PATCH net-next 0/5] Modernize bitbanged GPIO MDIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <421c14be-a712-5427-f3d6-ba29d69ed02c@gmail.com>
Date:   Tue, 27 Feb 2018 06:00:33 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Andrew Lunn <andrew@...n.ch>,
        "David S . Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH net-next 0/5] Modernize bitbanged GPIO MDIO



On 02/25/2018 04:51 AM, Linus Walleij wrote:
> This kills off the platform data support from the bitbanged
> GPIO-based MDIO driver and moves it over to using GPIO
> descriptors exclusively.
> 
> We are certainly not going to merge any more platforms into
> the kernel using platform data, and nothing is using it at the
> moment. The only concern would be out-of-tree platforms, and
> those are not the concern of the kernel community. They need
> to move to use device tree (or ACPI etc) like everyone else.

Please refrain from making statements like those because there are
perfectly valid use cases for never seeing ACPI or Device Tree for a
given platform, yes there will be push back, and yes, if DT or ACPI is
possible, it should be used but I can guarantee you there are platforms
out there that won't be converted to DT (e.g: tons of MIPS-based router,
x86 add-on modules etc.).

Nack on patches 1 and 3, because I am slowly resuming work on an x86
platform driver that uses the mdio-gpio driver with platform data, and
DT is not an option there, and I would rather not have to revert your
changes.

> 
> This was tested on the bit-banged GPIO MDIO on the D-Link
> DNS-313 and works fine for me.
> 
> Linus Walleij (5):
>   net: mdio-gpio: Localize platform data
>   net: mdio-gpio: Allocate state in probe()
>   net: mdio-gpio: Remove non-DT probe path
>   net: mdio-gpio: Merge platform data into state
>   net: mdio-gpio: Move to gpiod API
> 
>  MAINTAINERS                             |   1 -
>  drivers/net/phy/Kconfig                 |   2 +-
>  drivers/net/phy/mdio-gpio.c             | 151 ++++++++++----------------------
>  include/linux/platform_data/mdio-gpio.h |  33 -------
>  4 files changed, 47 insertions(+), 140 deletions(-)
>  delete mode 100644 include/linux/platform_data/mdio-gpio.h
> 

-- 
Florian