netdev - Re: [PATCH net-next 0/5] Modernize bitbanged GPIO MDIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbDho_9=ubYkyBc8w2wRcBWDeUKeTUq+7XrS=nN0y6T0w@mail.gmail.com>
Date:   Tue, 27 Feb 2018 09:53:05 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH net-next 0/5] Modernize bitbanged GPIO MDIO

On Sun, Feb 25, 2018 at 8:08 PM, Andrew Lunn <andrew@...n.ch> wrote:
> On Sun, Feb 25, 2018 at 01:51:27PM +0100, Linus Walleij wrote:
>> This kills off the platform data support from the bitbanged
>> GPIO-based MDIO driver and moves it over to using GPIO
>> descriptors exclusively.
>
> Hi Linus
>
> I like where this ends up. I wounder about the path it takes to get
> there. There seems to be quite a lot of code which gets moved around
> and then in the end deleted. Maybe changing the order of the patches
> would help. Converting to devm_gpiod_get_index() first would remove
> all the active_low flags. Then remove all the unused reset callback,
> irq, etc?

It's mainly a matter of which order we want bisects to end up...

I was thinking to order the patches from least-likely to cause
regressions to most-likely to cause regressions so that it is
later possible to revert the more likely regression cause without
getting into conflict with the rest.

Yours,
Linus Walleij