netdev - Re: [PATCH net-next 01/11] ipmr,ipmr6: Define a uniform vif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cdee2c6e-6d18-586c-bb5f-9f3e3ff48c66@cumulusnetworks.com>
Date:   Tue, 27 Feb 2018 21:36:18 +0200
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Yuval Mintz <yuvalm@...lanox.com>, netdev@...r.kernel.org
Cc:     mlxsw@...lanox.com, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH net-next 01/11] ipmr,ipmr6: Define a uniform vif_device

On 27/02/18 20:58, Yuval Mintz wrote:
> The two implementations have almost identical structures - vif_device and
> mif_device. As a step toward uniforming the mr_tables, eliminate the
> mif_device and relocate the vif_device definition into a new common
> header file.
> 
> Also, introduce a common initializing function for setting most of the
> vif_device fields in a new common source file. This requires modifying
> the ipv{4,6] Kconfig and ipv4 makefile as we're introducing a new common
> config option - CONFIG_IP_MROUTE_COMMON.
> 
> Signed-off-by: Yuval Mintz <yuvalm@...lanox.com>
> ---
>  include/linux/mroute.h      | 13 +-----------
>  include/linux/mroute6.h     | 11 +---------
>  include/linux/mroute_base.h | 52 +++++++++++++++++++++++++++++++++++++++++++++
>  net/ipv4/Kconfig            |  5 +++++
>  net/ipv4/Makefile           |  1 +
>  net/ipv4/ipmr.c             | 32 +++++++++++++---------------
>  net/ipv4/ipmr_base.c        | 28 ++++++++++++++++++++++++
>  net/ipv6/Kconfig            |  1 +
>  net/ipv6/ip6mr.c            | 37 ++++++++++++--------------------
>  9 files changed, 117 insertions(+), 63 deletions(-)
>  create mode 100644 include/linux/mroute_base.h
>  create mode 100644 net/ipv4/ipmr_base.c
> 

Acked-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>